Bea Esguerra | I don't see any code changes to this story in the PR! Was this expected to change? |
Good question! I wonder if it's related to the removal of MediaLayout. The styles for small became the default. I'll play with it and see if it changes things!
I actually wonder if this was a prior issue with MediaLayout and specificity. When a style is passed in through props, should it override a media query that matches? In this case, the maxWidth style in the story is overridden by the midOrLarger media query. The old MediaLayout mdOrLarger may not have been applied in the same way as Aphrodite styles, and it was overridden at the snapshot viewport size. Maybe the custom style should be something more straightforward, or the story could be set to a smaller viewport size? I confirmed the maxWidth style in the story is being applied at smaller viewport sizes.
Related to this, MediaLayout mdOrLarger had a different value than our media query breakpoint for mdOrLarger . So I added a breakpoint to match the old value so we can have better backwards compatibility (and move some TODOs for 767px breakpoints out of comments and into tokens).
Approving the snapshot for now to move things along! In the PR thread, I mentioned it could be helpful to update the WithStyle example so we can show how consumers could override the max width!