Baseline History
Build 72761ae04cc current baseline
Current build. Accepted by Bea Esguerra with 8 comments.
Build 69380e9a91c
Accepted by Bea Esguerra.
Commenting is disabled because there's a newer build on this branch. Go to Build 7296 now
Pinned
Bea Esguerra | The disabled checked state looks different in the design! https://www.figma.com/design/EuFu0U7gqc1koXm8ZhlOLp/%E2%9A%A1%EF%B8%8F-Components?node-id=6812-3676&t=TPUXPGwAA85uPksQ-4 | Resolved |
Bea Esguerra | The checkbox unchecked in TB has a different border color and background color: https://www.figma.com/design/EuFu0U7gqc1koXm8ZhlOLp/%E2%9A%A1%EF%B8%8F-Components?node-id=2048-80&t=TPUXPGwAA85uPksQ-4 | Resolved |
Bea Esguerra | We have started to migrate things to use the global focus style, could we use it for the checkbox and radio buttons too? | Resolved |
Bea Esguerra | (This is pre-existing so it can be for another ticket!) - Do we want the disabled state to be focusable, similar to other components in WB (using aria-disabled instead of disabled?) | Resolved |
Bea Esguerra | Comparing the typography in the designs: The label in the design uses #191918, in the browser it shows #000000 The line-height in the design also shows 14px, the browser shows 20px The font-weight in the design uses Semi, and the browser shows the medium font-weight token is used I don't see any TB designs for the description part so I didn't compare that to anything! (same with the states that aren't in the design like press, hover, error) | Resolved |
Bea Esguerra | It isn't as noticeable in the snapshot, however, in the browser, the vertical alignment of the checkbox and the label is a bit off! | Resolved |
Bea Esguerra | The checked state doesn't have a border in the design! | Resolved |
Bea Esguerra | There isn't a design for the error state so I can't compare! However, could we make the border on the checkbox darker or transparent? | Resolved |