PopoverContentCore:Dark

Build 6005 on semantic-poptip
Reviewing disabled
View latest build
BaselineBuild 4843 on sb-reorg
View Storybook
LatestBuild 6005 on semantic-poptip
View Storybook
Baseline History
Build 6005c0cb49c current baseline
Current build. Accepted by Bea Esguerra with 1 comment.
Build 4843fdef4af
Accepted by Juan Andrade.
Commenting is disabled because there's a newer build on this branch. Go to Build 6053 now
Bea Esguerra
Bea Esguerra
1y ago on build 6005

The changes look fine to me, though wanted to check with you first! Seems like it's highlighting the corners and the bottom border (I can only see it with the magnifying glass when the strobe changes feature is on). Is this intended?


Is it similar to what is shown in the next 2 diffs also?

Juan Andrade
Juan Andrade
1y ago on build 6005

I'm not sure if it is an issue with the Chromatic diffing algorithm. The change that I did there was to switch the border-color from color.offBlack16 to color.fadedOffBlack16. I'm not sure if changing from rgba to hex has that effect (it probably does). This should be expected as we are trying to align on the HEX usage between Design and Eng.

Bea Esguerra
Bea Esguerra
1y ago on build 6005

Sounds good! Thanks for confirming!